From 6a00a17c145d7eee2fb1d87218a9116c7d7a773f Mon Sep 17 00:00:00 2001 From: Shridhar Patil Date: Mon, 11 Jun 2018 12:48:31 +0530 Subject: [PATCH 1/2] toggle required fields on select of repayment option in loan application --- erpnext/hr/doctype/loan_application/loan_application.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/erpnext/hr/doctype/loan_application/loan_application.js b/erpnext/hr/doctype/loan_application/loan_application.js index 2c0f2d19d1..c0660ada68 100644 --- a/erpnext/hr/doctype/loan_application/loan_application.js +++ b/erpnext/hr/doctype/loan_application/loan_application.js @@ -11,11 +11,16 @@ frappe.ui.form.on('Loan Application', { repayment_method: function(frm) { frm.doc.repayment_amount = frm.doc.repayment_periods = "" frm.trigger("toggle_fields") + frm.trigger("toogle_required") }, toggle_fields: function(frm) { frm.toggle_enable("repayment_amount", frm.doc.repayment_method=="Repay Fixed Amount per Period") frm.toggle_enable("repayment_periods", frm.doc.repayment_method=="Repay Over Number of Periods") }, + toogle_required: function(frm){ + frm.toggle_reqd("repayment_amount", cint(frm.doc.repayment_method=='Repay Fixed Amount per Period')) + frm.toggle_reqd("repayment_periods", cint(frm.doc.repayment_method=='Repay Over Number of Periods')) + }, add_toolbar_buttons: function(frm) { if (frm.doc.status == "Approved") { frm.add_custom_button(__('Loan'), function() { From c3f5849ac0274ea76d66b864058bf968dc5ab1f3 Mon Sep 17 00:00:00 2001 From: Shridhar Patil Date: Mon, 11 Jun 2018 18:26:45 +0530 Subject: [PATCH 2/2] typo fixed --- erpnext/hr/doctype/loan_application/loan_application.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/hr/doctype/loan_application/loan_application.js b/erpnext/hr/doctype/loan_application/loan_application.js index c0660ada68..febcbd88e7 100644 --- a/erpnext/hr/doctype/loan_application/loan_application.js +++ b/erpnext/hr/doctype/loan_application/loan_application.js @@ -11,13 +11,13 @@ frappe.ui.form.on('Loan Application', { repayment_method: function(frm) { frm.doc.repayment_amount = frm.doc.repayment_periods = "" frm.trigger("toggle_fields") - frm.trigger("toogle_required") + frm.trigger("toggle_required") }, toggle_fields: function(frm) { frm.toggle_enable("repayment_amount", frm.doc.repayment_method=="Repay Fixed Amount per Period") frm.toggle_enable("repayment_periods", frm.doc.repayment_method=="Repay Over Number of Periods") }, - toogle_required: function(frm){ + toggle_required: function(frm){ frm.toggle_reqd("repayment_amount", cint(frm.doc.repayment_method=='Repay Fixed Amount per Period')) frm.toggle_reqd("repayment_periods", cint(frm.doc.repayment_method=='Repay Over Number of Periods')) },