Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

removed validate approver code

Browse Source
This commit is contained in:
Anand Doshi 2012-07-31 11:46:41 +05:30
parent 85632b71c9
commit 054cf3907f
2 changed files with 2 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
erpnext/hr/doctype/expense_claim/expense_claim.js
View File

@ -67,17 +67,6 @@ cur_frm.cscript.calculate_total = function(doc,cdt,cdn){
}
doc.total_claimed_amount = flt(total_claim);
refresh_field('total_claimed_amount');
$c_obj(make_doclist(doc.doctype, doc.name),'validate_approver','', function(r,rt){
if(r.message){
if(r.message['valid_approver'] == 'No'){
doc.exp_approver ='';
}
get_field(doc.doctype, 'exp_approver' , doc.name).options = '';
get_field(doc.doctype, 'exp_approver' , doc.name).options = r.message['app_lst'];
refresh_field('exp_approver');
}
});
}
else if(doc.approval_status == 'Submitted'){
var val = getchildren('Expense Claim Detail', doc.name, 'expense_voucher_details', doc.doctype);
@ -251,4 +240,4 @@ cur_frm.cscript.on_submit = function(doc, cdt, cdn) {
send_to: doc.exp_approver
}
cur_frm.cscript.notify(doc, args);
}
}

12
erpnext/hr/doctype/expense_claim/expense_claim.py
View File

@ -140,17 +140,7 @@ class DocType:
if not self.doc.exp_approver:
msgprint("Please select Expense Claim approver")
raise Exception
def validate_approver(self):
app_lst = self.get_approver_lst()
if self.doc.exp_approver and self.doc.exp_approver not in app_lst:
msgprint("Approver "+self.doc.exp_approver+" is not authorized to approve this expense voucher. Please select another approver")
valid_app = 'No'
else:
valid_app = 'Yes'
ret = {'app_lst':("\n" + "\n".join(app_lst)), 'valid_approver':valid_app}
return ret
def on_submit(self):
self.validate_exp_details()
set(self.doc, 'approval_status', 'Submitted')