Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[fix] Validate deletion of serial no

Browse Source
This commit is contained in:
Nabin Hait 2015-09-22 09:09:11 +05:30
parent d91382dbf3
commit 03afb45e34
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
erpnext/stock/doctype/serial_no/serial_no.py
View File

@ -139,10 +139,19 @@ class SerialNo(StockController):
return sle_dict
def on_trash(self):
if self.warehouse:
frappe.throw(_("Cannot delete Serial No {0} in stock. First remove from stock, then delete.").format(self.name))
elif self.delivery_document_no:
frappe.throw(_("Delivered Serial No {0} cannot be deleted").format(self.name))
sl_entries = frappe.db.sql("""select serial_no from `tabStock Ledger Entry`
where serial_no like %s and item_code=%s and ifnull(is_cancelled, 'No')='No'""",
("%%%s%%" % self.name, self.item_code), as_dict=True)
# Find the exact match
sle_exists = False
for d in sl_entries:
if self.name.upper() in get_serial_nos(d.serial_no):
sle_exists = True
break
if sle_exists:
frappe.throw(_("Cannot delete Serial No {0}, as it is used in stock transactions").format(self.name))
def before_rename(self, old, new, merge=False):
if merge: