Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #27990 from noahjacob/maint_schedule_fix

Browse Source 
fix: changes in schedules gets overwritten on save
This commit is contained in:
Noah Jacob 2021-10-19 13:36:52 +05:30 committed by GitHub
commit 01bb97bd09
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/maintenance/doctype/maintenance_schedule/maintenance_schedule.py
View File

@ -199,12 +199,16 @@ class MaintenanceSchedule(TransactionBase):
if chk: if chk:
throw(_("Maintenance Schedule {0} exists against {1}").format(chk[0][0], d.sales_order)) throw(_("Maintenance Schedule {0} exists against {1}").format(chk[0][0], d.sales_order))
def validate_no_of_visits(self):
return len(self.schedules) != sum(d.no_of_visits for d in self.items)
def validate(self): def validate(self):
self.validate_end_date_visits() self.validate_end_date_visits()
self.validate_maintenance_detail() self.validate_maintenance_detail()
self.validate_dates_with_periodicity() self.validate_dates_with_periodicity()
self.validate_sales_order() self.validate_sales_order()
self.generate_schedule() if not self.schedules or self.validate_no_of_visits():
self.generate_schedule()
def on_update(self): def on_update(self):
frappe.db.set(self, 'status', 'Draft') frappe.db.set(self, 'status', 'Draft')