Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #34298 from s-aga-r/fix-22-23-05638-1

Browse Source 
fix: update inventory dimensions before returning sle
This commit is contained in:
Sagar Sharma 2023-03-04 16:50:55 +05:30 committed by GitHub
commit 0185096e09
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py
View File

@ -397,6 +397,7 @@ class StockReconciliation(StockController):
"voucher_type": self.doctype,
"voucher_no": self.name,
"voucher_detail_no": row.name,
"actual_qty": flt(row.current_qty),
"company": self.company,
"stock_uom": frappe.db.get_value("Item", row.item_code, "stock_uom"),
"is_cancelled": 1 if self.docstatus == 2 else 0,
@ -406,8 +407,6 @@ class StockReconciliation(StockController):
}
)
self.update_inventory_dimensions(row, data)
if not row.batch_no:
data.qty_after_transaction = flt(row.qty, row.precision("qty"))
@ -425,6 +424,8 @@ class StockReconciliation(StockController):
data.valuation_rate = flt(row.valuation_rate)
data.stock_value_difference = -1 * flt(row.amount_difference)
self.update_inventory_dimensions(row, data)
return data
def make_sle_on_cancel(self):