From 00b0f10100a2d38e73cd415c7f0839b68cbaa62d Mon Sep 17 00:00:00 2001
From: Subin Tom <subintom2@gmail.com>
Date: Fri, 25 Feb 2022 13:38:57 +0530
Subject: [PATCH] fix: added type of call select field, additional status for
 agent rejecting call

---
 erpnext/erpnext_integrations/exotel_integration.py |  2 ++
 erpnext/public/js/call_popup/call_popup.js         | 13 ++++++++++++-
 erpnext/telephony/doctype/call_log/call_log.json   | 11 +++++++++--
 erpnext/telephony/doctype/call_log/call_log.py     |  4 +++-
 4 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/erpnext/erpnext_integrations/exotel_integration.py b/erpnext/erpnext_integrations/exotel_integration.py
index c4f6636239..a94596933d 100644
--- a/erpnext/erpnext_integrations/exotel_integration.py
+++ b/erpnext/erpnext_integrations/exotel_integration.py
@@ -41,6 +41,8 @@ def handle_missed_call(**kwargs):
 		status = 'No Answer'
 	elif CallType == "client-hangup" and DialCallStatus == "canceled":
 		status = 'Canceled'
+	elif CallType == "incomplete" and DialCallStatus == "failed":
+		status = 'Failed'
 
 	update_call_log(kwargs, status)
 
diff --git a/erpnext/public/js/call_popup/call_popup.js b/erpnext/public/js/call_popup/call_popup.js
index c954f12ac6..2addeae0e5 100644
--- a/erpnext/public/js/call_popup/call_popup.js
+++ b/erpnext/public/js/call_popup/call_popup.js
@@ -141,6 +141,15 @@ class CallPopup {
 				'fieldtype': 'Section Break',
 				'hide_border': 1,
 			}, {
+				'fieldname': 'type_of_call',
+				'label': 'Type Of Call',
+				'fieldtype': 'Select',
+				'options': '\nFrappe Cloud Queries/Plan\nEnterprise Plans\nPartnership\nSupport\nBilling/Renewal\nOpen source / Junk',
+				'default': 'Frappe Cloud Queries/Plan',
+			},{
+				'fieldtype': 'Section Break',
+				'hide_border': 1,
+			},{
 				'fieldtype': 'Small Text',
 				'label': __('Call Summary'),
 				'fieldname': 'call_summary',
@@ -149,10 +158,12 @@ class CallPopup {
 				'label': __('Save'),
 				'click': () => {
 					const call_summary = this.call_details.get_value('call_summary');
+					const call_type = this.call_details.get_value('type_of_call');
 					if (!call_summary) return;
-					frappe.xcall('erpnext.telephony.doctype.call_log.call_log.add_call_summary', {
+					frappe.xcall('erpnext.telephony.doctype.call_log.call_log.add_call_summary_and_call_type', {
 						'call_log': this.call_log.name,
 						'summary': call_summary,
+						'call_type': call_type,
 					}).then(() => {
 						this.close_modal();
 						frappe.show_alert({
diff --git a/erpnext/telephony/doctype/call_log/call_log.json b/erpnext/telephony/doctype/call_log/call_log.json
index c0f022b020..615e069e72 100644
--- a/erpnext/telephony/doctype/call_log/call_log.json
+++ b/erpnext/telephony/doctype/call_log/call_log.json
@@ -22,6 +22,7 @@
   "recording_url",
   "recording_html",
   "section_break_11",
+  "type_of_call",
   "summary",
   "section_break_19",
   "links"
@@ -105,7 +106,8 @@
   },
   {
    "fieldname": "summary",
-   "fieldtype": "Small Text"
+   "fieldtype": "Small Text",
+   "label": "Summary"
   },
   {
    "fieldname": "section_break_11",
@@ -149,12 +151,17 @@
    "fieldtype": "Data",
    "hidden": 1,
    "label": "Employee User Id"
+  },
+  {
+   "fieldname": "type_of_call",
+   "fieldtype": "Data",
+   "label": "Type Of Call"
   }
  ],
  "in_create": 1,
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2022-02-23 19:47:04.310577",
+ "modified": "2022-02-25 13:37:48.156501",
  "modified_by": "Administrator",
  "module": "Telephony",
  "name": "Call Log",
diff --git a/erpnext/telephony/doctype/call_log/call_log.py b/erpnext/telephony/doctype/call_log/call_log.py
index 787015169b..e55d2906c9 100644
--- a/erpnext/telephony/doctype/call_log/call_log.py
+++ b/erpnext/telephony/doctype/call_log/call_log.py
@@ -103,8 +103,10 @@ def get_employee_name(emp):
 
 
 @frappe.whitelist()
-def add_call_summary(call_log, summary):
+def add_call_summary_and_call_type(call_log, summary, call_type):
 	doc = frappe.get_doc('Call Log', call_log)
+	doc.type_of_call = call_type
+	doc.save()
 	doc.add_comment('Comment', frappe.bold(_('Call Summary')) + '<br><br>' + summary)
 
 def get_employees_with_number(number):