Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: asset finance books validation (#36979)

Browse Source
This commit is contained in:
Anand Baburajan 2023-09-06 12:44:07 +05:30 committed by GitHub
parent 8ce6b8179e
commit 0077659e93
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
erpnext/assets/doctype/asset/asset.py
View File

@ -46,6 +46,7 @@ class Asset(AccountsController):
self.validate_item() self.validate_item()
self.validate_cost_center() self.validate_cost_center()
self.set_missing_values() self.set_missing_values()
self.validate_finance_books()
if not self.split_from: if not self.split_from:
self.prepare_depreciation_data() self.prepare_depreciation_data()
update_draft_asset_depr_schedules(self) update_draft_asset_depr_schedules(self)
@ -200,6 +201,27 @@ class Asset(AccountsController):
finance_books = get_item_details(self.item_code, self.asset_category) finance_books = get_item_details(self.item_code, self.asset_category)
self.set("finance_books", finance_books) self.set("finance_books", finance_books)
def validate_finance_books(self):
if not self.calculate_depreciation or len(self.finance_books) == 1:
return
finance_books = set()
for d in self.finance_books:
if d.finance_book in finance_books:
frappe.throw(
_("Row #{}: Please use a different Finance Book.").format(d.idx),
title=_("Duplicate Finance Book"),
)
else:
finance_books.add(d.finance_book)
if not d.finance_book:
frappe.throw(
_("Row #{}: Finance Book should not be empty since you're using multiple.").format(d.idx),
title=_("Missing Finance Book"),
)
def validate_asset_values(self): def validate_asset_values(self):
if not self.asset_category: if not self.asset_category:
self.asset_category = frappe.get_cached_value("Item", self.item_code, "asset_category") self.asset_category = frappe.get_cached_value("Item", self.item_code, "asset_category")