brotherton-erpnext/erpnext/patches/v14_0/discount_accounting_separation.py

import frappe


def execute():
	data = frappe.db.sql(
		'select value from tabSingles where doctype="Accounts Settings" and field="enable_discount_accounting"'
	)
	discount_account = data and int(data[0][0]) or 0
	if discount_account:
		for doctype in ["Buying Settings", "Selling Settings"]:
			frappe.db.set_single_value(doctype, "enable_discount_accounting", 1, update_modified=False)
fix(patch): enable discount account in buying and selling if exist in accounts settings 2022-04-08 11:57:53 +00:00			`import frappe`

fix: tabspacing 2022-04-14 10:12:16 +00:00
fix(patch): enable discount account in buying and selling if exist in accounts settings 2022-04-08 11:57:53 +00:00			`def execute():`
fix(minor): discount accounting patch 2022-05-01 06:55:21 +00:00			`data = frappe.db.sql(`
			`'select value from tabSingles where doctype="Accounts Settings" and field="enable_discount_accounting"'`
			`)`
fix(minor): fix create_accounting_dimensions_in_orders.py 2022-05-02 04:11:12 +00:00			`discount_account = data and int(data[0][0]) or 0`
fix: tabspacing 2022-04-14 10:12:16 +00:00			`if discount_account:`
			`for doctype in ["Buying Settings", "Selling Settings"]:`
refactor: Use `db.set_single_value` (#35668) I just applied semgrep autofix. Untested completed, review before merging. ```yaml - id: frappe-set-value-semantics patterns: - pattern-either: - pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER) - pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER) fix: frappe.db.set_single_value($DOCTYPE, $...AFTER) message: \| If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead. languages: [python] severity: ERROR ``` 2023-06-13 12:00:38 +00:00			`frappe.db.set_single_value(doctype, "enable_discount_accounting", 1, update_modified=False)`