brotherton-erpnext/.github/helper/semgrep_rules/report.yml

rules:
- id: frappe-missing-translate-function-in-report-python
  paths:
    include:
    - "**/report"
    exclude:
    - "**/regional"
  pattern-either:
  - patterns:
      - pattern: |
          {..., "label": "...", ...}
      - pattern-not: |
          {..., "label": _("..."), ...}
  - patterns:
      - pattern: dict(..., label="...", ...)
      - pattern-not: dict(..., label=_("..."), ...)
  message: |
      All user facing text must be wrapped in translate function. Please refer to translation documentation. https://frappeframework.com/docs/user/en/guides/basics/translations
  languages: [python]
  severity: ERROR

- id: frappe-translated-values-in-business-logic
  paths:
    include:
    - "**/report"
  patterns:
    - pattern-inside: |
        {..., filters: [...], ...}
    - pattern: |
        {..., options: [..., __("..."), ...], ...}
  message: |
      Using translated values in options field will require you to translate the values while comparing in business logic. Instead of passing translated labels provide objects that contain both label and value. e.g. { label: __("Option value"), value: "Option value"}
  languages: [javascript]
  severity: ERROR